Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor variable name from lazyrouter to lazyRouter for camel case consistency #5755

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KNU-K
Copy link

@KNU-K KNU-K commented Jul 10, 2024

The camel case convention seems to be the standard naming convention used in this project, and "lazyrouter" does not conform to this standard. I believe it would be better to change it to "lazyRouter". What do you think? Additionally, are there any other areas that might need revision?

@KNU-K
Copy link
Author

KNU-K commented Jul 10, 2024

I want to get permission to proceed. Therefore, overall changes have not been made. What do you think about this?

@wesleytodd
Copy link
Member

This is an undocumented and intended to be private method but changing it would be a breaking change which cannot land in v4. IMO we should not make changes to it until we remove it completely in a future major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants